Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgis: Rename ap_copy to aq for G_aprintf #3651

Merged
merged 1 commit into from
Apr 23, 2024
Merged

libgis: Rename ap_copy to aq for G_aprintf #3651

merged 1 commit into from
Apr 23, 2024

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented Apr 23, 2024 •
edited
Loading

This PR simply renames ap_copy to aq. I just like this name better from the va_copy man page ;-).

@HuidaeCho HuidaeCho added C Related code is in C libraries labels Apr 23, 2024
echoix
echoix previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no mentions in docs to adjust (assuming it's in the private part of the library), shouldn't be a problem.

@echoix
Copy link
Member

echoix commented Apr 23, 2024

But what does aq mean? Is it a convention?

@HuidaeCho
Copy link
Member Author

But what does aq mean? Is it a convention?

aq next to ap just like i, j...

@echoix
Copy link
Member

echoix commented Apr 23, 2024

And ap was for the ap in aprintf ?

@echoix echoix added this to the 8.4.0 milestone Apr 23, 2024
@HuidaeCho
Copy link
Member Author

And ap was for the ap in aprintf ?

I think "argument pointer"?

@HuidaeCho HuidaeCho enabled auto-merge (squash) April 23, 2024 04:39
@echoix
Copy link
Member

echoix commented Apr 23, 2024

Maybe aq isn't as descriptive then, since it isn't just an loop variable, but had a meaning (that variable had to be copied as we saw from the vasprintf bug that #3650 would fix)

@echoix echoix dismissed their stale review April 23, 2024 04:57

I'm not sure enough now

@HuidaeCho
Copy link
Member Author

But what does aq mean? Is it a convention?

I think it became kind of a convention because it's from the man page of va_copy:

@echoix
Copy link
Member

echoix commented Apr 23, 2024

But what does aq mean? Is it a convention?

I think it became kind of a convention because it's from the man page of va_copy:

You convinced me easily!

@HuidaeCho HuidaeCho merged commit 5661bad into OSGeo:main Apr 23, 2024
26 checks passed
@HuidaeCho HuidaeCho deleted the aprintf_rename_ap_copy branch April 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
C Related code is in C libraries
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HuidaeCho @echoix